Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect filenames in a document for Windows #12343

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

wonseop
Copy link
Contributor

@wonseop wonseop commented Jan 4, 2024

Motivation/summary

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document. I corrected an incorrect filename in the documentation for Windows.

Checklist

  • Documentation has been updated

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.
@wonseop wonseop requested a review from a team as a code owner January 4, 2024 06:15
Copy link
Contributor

mergify bot commented Jan 4, 2024

This pull request does not have a backport label. Could you fix it @wonseop? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 4, 2024
@wonseop
Copy link
Contributor Author

wonseop commented Jan 4, 2024

@carsonip This is the same PR as #12312.
I succeeded in signing the commit.😊

@carsonip carsonip added backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 4, 2024
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@reakaleek
Copy link
Member

jenkins test this please

@carsonip carsonip merged commit 5e0077d into elastic:main Jan 4, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)
mergify bot added a commit that referenced this pull request Jan 4, 2024
)

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)

Co-authored-by: Wonseop Kim <[email protected]>
mergify bot added a commit that referenced this pull request Jan 4, 2024
)

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)

Co-authored-by: Wonseop Kim <[email protected]>
mergify bot added a commit that referenced this pull request Jan 4, 2024
)

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)

Co-authored-by: Wonseop Kim <[email protected]>
mergify bot added a commit that referenced this pull request Jan 4, 2024
)

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)

Co-authored-by: Wonseop Kim <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jan 4, 2024
)

After 8.5.0, the file name was changed from install-service-apm-server.ps1 to install-service.ps1, but it was not modified in the document.
I corrected an incorrect filename in the documentation for Windows.

(cherry picked from commit 5e0077d)

Co-authored-by: Wonseop Kim <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@wonseop wonseop deleted the fix_file_name branch January 4, 2024 14:58
v1v added a commit to v1v/apm-server that referenced this pull request Jan 10, 2024
* feature/patch-release: (249 commits)
  Update release.mk
  [updatecli] Bump elastic stack version to 8.13.0-8upz6ftd (elastic#12380)
  chore: Update to elastic/beats@95f0f85a3edd (elastic#12370)
  ci(release): automate release steps for the minor (elastic#12233)
  build(deps): bump the github-actions group with 1 update (elastic#12365)
  chore: Update to elastic/beats@d1b32774aef4 (elastic#12362)
  [updatecli] Bump elastic stack version to 8.13.0-ybxdr713 (elastic#12349)
  chore: Update to elastic/beats@81ebafc4c2da (elastic#12352)
  [apm docs consolidation] Delete moved files, update README (elastic#12341)
  [updatecli] Bump elastic stack version to 8.13.0-toucn398 (elastic#12325)
  docs: fix incorrect filenames in a document for Windows (elastic#12343)
  chore: Update to elastic/beats@6f192c01ef19 (elastic#12337)
  build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (elastic#12237)
  Update NOTICE.txt year (elastic#12333)
  build(deps): bump the github-actions group with 1 update (elastic#12322)
  [updatecli] Bump elastic stack version to 8.13.0-4f8l51qr (elastic#12315)
  docs: Update known issues as fix was released (elastic#12196)
  feat: use latest apm-data to set success `event.outcome` when otel span.Status is Unset (elastic#12199)
  [updatecli] Bump elastic stack version to 8.13.0-4aavtlfc (elastic#12304)
  chore: rename apm-mutating-webhook to apm-k8s-attacher (elastic#12222)
  ...
colleenmcginnis added a commit to colleenmcginnis/observability-docs that referenced this pull request Jan 12, 2024
colleenmcginnis added a commit to elastic/observability-docs that referenced this pull request Jan 12, 2024
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Jan 12, 2024
* copy over changes from elastic/apm-server#12343

* copy over changes from elastic/apm-server#12196

* copy over changes from elastic/apm-server#12222

(cherry picked from commit e691982)
colleenmcginnis added a commit to elastic/observability-docs that referenced this pull request Jan 12, 2024
…3542)

* copy over changes from elastic/apm-server#12343

* copy over changes from elastic/apm-server#12196

* copy over changes from elastic/apm-server#12222

(cherry picked from commit e691982)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants